Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONSUMERBANK-582] Put bank tab in correct position #4301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mats-stripe
Copy link
Collaborator

@mats-stripe mats-stripe commented Nov 25, 2024

Summary

This updates the payment sheet to place the Instant Debits / Panther bank tab at the index for link we get in the elementsSession.orderedPaymentMethodTypes response field. This matches the behaviour we currently have in the web payment elements.

Motivation

CONSUMERBANK-582

Testing

Unit tests added

Changelog

N/a

@mats-stripe mats-stripe requested review from a team as code owners November 25, 2024 16:26
@mats-stripe mats-stripe force-pushed the mats/bank_tab_position branch from 3859ba3 to c738f24 Compare November 25, 2024 16:28
Copy link

github-actions bot commented Nov 25, 2024

⚠️ Public API changes detected:

StripePayments

- get
- }
- public var crypto: StripePayments.STPPaymentMethodCrypto? {
- case crypto
- public var crypto: StripePayments.STPPaymentMethodCryptoParams?
- public init(crypto: StripePayments.STPPaymentMethodCryptoParams, billingDetails: StripePayments.STPPaymentMethodBillingDetails?, metadata: [Swift.String : Swift.String]?)
- public var allResponseFields: [Swift.AnyHashable : Any] {
- get
- }
- public var description: Swift.String {
- @objc get
- }
- public class func decodedObject(fromAPIResponse response: [Swift.AnyHashable : Any]?) -> Self?
- @objc deinit
- public var additionalAPIParameters: [Swift.AnyHashable : Any]
- public class func rootObjectName() -> Swift.String?
- public class func propertyNamesToFormFieldNamesMapping() -> [Swift.String : Swift.String]
- public init()
- @objc deinit

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@mats-stripe mats-stripe changed the title Mats/bank tab position [CONSUMERBANK-582] Put bank tab in correct position Nov 25, 2024
@mats-stripe mats-stripe force-pushed the mats/bank_tab_position branch 2 times, most recently from 5ec46f2 to c9fc2cd Compare November 26, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant